Summary: | Create a DOMHTMLVideoElement when wrapping <video> elements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, andersca, mitz, ossy, sam, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2016-03-05 20:50:54 PST
Created attachment 273124 [details]
Patch
Comment on attachment 273124 [details]
Patch
This seems API-testable
Sure, I suppose it is. (In reply to comment #5) > http://trac.webkit.org/changeset/197633 It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:36:9: fatal error: 'DOMHTMLVideoElement.h' file not found #import "DOMHTMLVideoElement.h" ^ (In reply to comment #7) > r197892 should fix that. No, it didn't fix. /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found #import "DOMHTMLVideoElement.h" ^ 1 error generated. (In reply to comment #8) > (In reply to comment #7) > > r197892 should fix that. > > No, it didn't fix. > > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/ > DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found > #import "DOMHTMLVideoElement.h" > ^ > 1 error generated. Still broken due to this error. one more fix landed in http://trac.webkit.org/changeset/198397, but the build is still broken: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59: /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error: 'WebCore/DOMHTMLMediaElement.h' file not found #import <WebCore/DOMHTMLMediaElement.h> ^ 1 error generated. (In reply to comment #10) > one more fix landed in http://trac.webkit.org/changeset/198397, > but the build is still broken: > > In file included from > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/ > DOM.mm:59: > /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/ > DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error: > 'WebCore/DOMHTMLMediaElement.h' file not found > #import <WebCore/DOMHTMLMediaElement.h> > ^ > 1 error generated. More fixes landed in - http://trac.webkit.org/changeset/198398 - http://trac.webkit.org/changeset/198400 but the build is still broken ... |