Bug 155084

Summary: Create a DOMHTMLVideoElement when wrapping <video> elements
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, mitz, ossy, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Tim Horton
Reported 2016-03-05 20:50:54 PST
Create a DOMHTMLVideoElement when wrapping <video> elements
Attachments
Patch (1.64 KB, patch)
2016-03-05 20:51 PST, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-03-05 20:51:26 PST
Created attachment 273124 [details] Patch
Radar WebKit Bug Importer
Comment 2 2016-03-05 20:53:01 PST
<rdar://problem/24997193>
mitz
Comment 3 2016-03-05 20:53:19 PST
Comment on attachment 273124 [details] Patch This seems API-testable
Tim Horton
Comment 4 2016-03-05 20:55:17 PST
Sure, I suppose it is.
Tim Horton
Comment 5 2016-03-05 21:02:55 PST
http://trac.webkit.org/changeset/197633
Csaba Osztrogonác
Comment 6 2016-03-07 13:33:56 PST
(In reply to comment #5) > http://trac.webkit.org/changeset/197633 It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:36:9: fatal error: 'DOMHTMLVideoElement.h' file not found #import "DOMHTMLVideoElement.h" ^
Alex Christensen
Comment 7 2016-03-09 15:33:49 PST
r197892 should fix that.
Csaba Osztrogonác
Comment 8 2016-03-10 09:03:56 PST
(In reply to comment #7) > r197892 should fix that. No, it didn't fix. /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found #import "DOMHTMLVideoElement.h" ^ 1 error generated.
Csaba Osztrogonác
Comment 9 2016-03-18 00:55:01 PDT
(In reply to comment #8) > (In reply to comment #7) > > r197892 should fix that. > > No, it didn't fix. > > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/ > DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found > #import "DOMHTMLVideoElement.h" > ^ > 1 error generated. Still broken due to this error.
Csaba Osztrogonác
Comment 10 2016-03-18 06:47:57 PDT
one more fix landed in http://trac.webkit.org/changeset/198397, but the build is still broken: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59: /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error: 'WebCore/DOMHTMLMediaElement.h' file not found #import <WebCore/DOMHTMLMediaElement.h> ^ 1 error generated.
Csaba Osztrogonác
Comment 11 2016-03-18 08:06:01 PDT
(In reply to comment #10) > one more fix landed in http://trac.webkit.org/changeset/198397, > but the build is still broken: > > In file included from > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/ > DOM.mm:59: > /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/ > DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error: > 'WebCore/DOMHTMLMediaElement.h' file not found > #import <WebCore/DOMHTMLMediaElement.h> > ^ > 1 error generated. More fixes landed in - http://trac.webkit.org/changeset/198398 - http://trac.webkit.org/changeset/198400 but the build is still broken ...
Note You need to log in before you can comment on or make changes to this bug.