Summary: | build-webkit prints an error on iOS simulator bots | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dbates, ddkilzer, dean_johnson, lforschler, mitz, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2016-03-05 16:58:35 PST
xcodeSDK() returns an uninitialized value. main::setXcodeSDK(undef) called at Tools/Scripts/build-layouttestrelay line 63 This is easy to fix by checking xcodeSDK() for undefined in buildXCodeProject(): push(@extraOptions, ("-sdk", xcodeSDK())) if isIOSWebKit(); But I'm trying to understand why -sdk is added in buildXCodeProject() in the first place, not in XcodeOptions(). Created attachment 273120 [details]
naive fix
I don't quite understand the relationship between -sdk and SDKROOT, but looks like we don't need -sdk.
Comment on attachment 273120 [details] naive fix Clearing flags on attachment: 273120 Committed r197636: <http://trac.webkit.org/changeset/197636> All reviewed patches have been landed. Closing bug. |