Bug 155078

Summary: build-webkit prints an error on iOS simulator bots
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ddkilzer, dean_johnson, lforschler, mitz, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
naive fix none

Alexey Proskuryakov
Reported 2016-03-05 16:58:35 PST
https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Debug%20%28Build%29/builds/0/steps/compile-webkit/logs/stdio perl Tools/Scripts/copy-webkitlibraries-to-product-directory --sdk iphonesimulator --wksi /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSDevice9.0.a Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSSimulator9.0.a Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSDevice9.2.a Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSSimulator9.2.a Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/WebKitSystemInterface.h Use of uninitialized value $extraOptions[8] in system at /Volumes/Data/slave/ios-simulator-9-debug/build/Tools/Scripts/webkitdirs.pm line 1754.
Attachments
naive fix (2.29 KB, patch)
2016-03-05 20:07 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-03-05 17:49:32 PST
xcodeSDK() returns an uninitialized value.
Alexey Proskuryakov
Comment 2 2016-03-05 17:57:49 PST
main::setXcodeSDK(undef) called at Tools/Scripts/build-layouttestrelay line 63
Alexey Proskuryakov
Comment 3 2016-03-05 18:58:08 PST
This is easy to fix by checking xcodeSDK() for undefined in buildXCodeProject(): push(@extraOptions, ("-sdk", xcodeSDK())) if isIOSWebKit(); But I'm trying to understand why -sdk is added in buildXCodeProject() in the first place, not in XcodeOptions().
Alexey Proskuryakov
Comment 4 2016-03-05 20:07:42 PST
Created attachment 273120 [details] naive fix I don't quite understand the relationship between -sdk and SDKROOT, but looks like we don't need -sdk.
WebKit Commit Bot
Comment 5 2016-03-06 00:33:20 PST
Comment on attachment 273120 [details] naive fix Clearing flags on attachment: 273120 Committed r197636: <http://trac.webkit.org/changeset/197636>
WebKit Commit Bot
Comment 6 2016-03-06 00:33:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.