Summary: | Move QualifiedName from CustomElementInfo to JSCustomElementInterface | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, cdumez, commit-queue, esprehn+autocc, kangil.han | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 154907 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2016-03-05 00:02:12 PST
Created attachment 273069 [details]
Cleanup
Comment on attachment 273069 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=273069&action=review > Source/WebCore/dom/CustomElementDefinitions.cpp:-74 > - ASSERT(!m_nameMap.contains(fullName.localName())); Putting this assertion back per IRC discussion with kling & anttik. Committed r197612: <http://trac.webkit.org/changeset/197612> Either this or r197611 has caused memory corruption crashes on ASan and GuardMalloc bots. Ryosuke, are you around to take a look now? (In reply to comment #4) > Either this or r197611 has caused memory corruption crashes on ASan and > GuardMalloc bots. > > Ryosuke, are you around to take a look now? Do you know a link or the name of a test on which the crash happens? (In reply to comment #4) > Either this or r197611 has caused memory corruption crashes on ASan and > GuardMalloc bots. > > Ryosuke, are you around to take a look now? Fixed in http://trac.webkit.org/changeset/197624. |