Bug 155061

Summary: Move QualifiedName from CustomElementInfo to JSCustomElementInterface
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, esprehn+autocc, kangil.han
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Cleanup koivisto: review+

Description Ryosuke Niwa 2016-03-05 00:02:12 PST
Now that each custom element interface can be associated with exactly one custom element,
there is no need to separate the interface object from the qualified name.

Just store the associated qualified name in JSCustomElementInterface itself for simplicity.
Comment 1 Ryosuke Niwa 2016-03-05 00:13:03 PST
Created attachment 273069 [details]
Cleanup
Comment 2 Ryosuke Niwa 2016-03-05 00:29:15 PST
Comment on attachment 273069 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=273069&action=review

> Source/WebCore/dom/CustomElementDefinitions.cpp:-74
> -    ASSERT(!m_nameMap.contains(fullName.localName()));

Putting this assertion back per IRC discussion with kling & anttik.
Comment 3 Ryosuke Niwa 2016-03-05 00:31:27 PST
Committed r197612: <http://trac.webkit.org/changeset/197612>
Comment 4 Alexey Proskuryakov 2016-03-05 14:37:00 PST
Either this or r197611 has caused memory corruption crashes on ASan and GuardMalloc bots.

Ryosuke, are you around to take a look now?
Comment 5 Ryosuke Niwa 2016-03-05 16:24:50 PST
(In reply to comment #4)
> Either this or r197611 has caused memory corruption crashes on ASan and
> GuardMalloc bots.
> 
> Ryosuke, are you around to take a look now?

Do you know a link or the name of a test on which the crash happens?
Comment 6 Ryosuke Niwa 2016-03-05 17:23:45 PST
(In reply to comment #4)
> Either this or r197611 has caused memory corruption crashes on ASan and
> GuardMalloc bots.
> 
> Ryosuke, are you around to take a look now?

Fixed in http://trac.webkit.org/changeset/197624.