| Summary: | Begin implementing <attachment> painting on iOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, enrica, esprehn+autocc, glenn, kondapallykalyan, sam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2016-03-04 14:26:00 PST
Created attachment 273042 [details]
Patch
Attachment 273042 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderThemeIOS.h:115: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/rendering/RenderThemeIOS.h:116: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/rendering/RenderThemeIOS.h:117: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Could you please fix the tests? https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r197608%20(3666)/results.html (In reply to comment #4) > Could you please fix the tests? > > https://build.webkit.org/results/ > Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r197608%20(3666)/ > results.html Oh, weird! As I noted in the ChangeLog, I thought they were skipped. Maybe I had the directory name wrong. Will fix! Temporarily skipped in 197610. Next week there will be another <attachment> patch that completes the implementation and turns the tests back on. Also, are ref tests upside-down?! :D |