Bug 15504

Summary:

Fix crashers in SVGViewSpec::parseViewSpec

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

15503

Bug Blocks:

15495

Attachments:

Description	Flags
fix for crashers (and includes missing idl file)	mjs: review+

Eric Seidel (no email)

Reported 2007-10-14 02:06:11 PDT

Fix crashers in SVGViewSpec::parseViewSpec I'm also including the idl for SVGViewSpec as well as a tiny change in the JS bindings generator (it didn't handle multi-parent classes where all parents are just interfaces... which will eventually be needed by SVGViewSpec.idl for generation). There are other bugs yet to resolve before we can turn on SVGViewSpec generation however.

Attachments
fix for crashers (and includes missing idl file) (7.85 KB, patch) 2007-10-14 02:09 PDT, Eric Seidel (no email)	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2007-10-14 02:06:51 PDT

Unfortunately enabling the layout test I built for this is blocked by bug 15503.

Eric Seidel (no email)

Comment 2 2007-10-14 02:09:05 PDT

Created attachment 16664 [details] fix for crashers (and includes missing idl file)

Maciej Stachowiak

Comment 3 2007-10-14 13:20:54 PDT

Comment on attachment 16664 [details] fix for crashers (and includes missing idl file) This looks ok, but as discussed let's find an alternate way to make the test work, or at least land it disabled and/or as a manual test.

Eric Seidel (no email)

Comment 4 2007-10-18 00:40:46 PDT

One more set of repro crashers down! r26740

Note You need to log in before you can comment on or make changes to this bug.