Bug 155033

Summary: REGRESSION (r197531): JavaScriptCore ASan build fails due to weak external symbol
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, ggaren, keith_miller, mark.lam, msaboff, rniwa, ryanhaddad, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154877    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2016-03-04 12:42:45 PST
JavaScriptCore ASan build fails due to weak external symbol:

PhaseScriptExecution Check For Weak VTables and Externals
ERROR: JavaScriptCore has a weak external symbol in it (/Volumes/Data/BuildSlave/Monarch-WebKitASan/build/OpenSource/WebKitBuild/Debug-iphonesimulator/JavaScriptCore.framework/JavaScriptCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol __ZNK3JSC8JSObject19ordinaryToPrimitiveEPNS_9ExecStateENS_22PreferredPrimitiveTypeE

This regressed with:

Bug 154877: [ES6] Add support for Symbol.toPrimitive
<https://bugs.webkit.org/show_bug.cgi?id=154877>
<http://trac.webkit.org/changeset/197531>
Comment 1 David Kilzer (:ddkilzer) 2016-03-04 12:43:53 PST
<rdar://problem/24979661>
Comment 2 David Kilzer (:ddkilzer) 2016-03-04 12:45:20 PST
Created attachment 273026 [details]
Patch v1
Comment 3 Alexey Proskuryakov 2016-03-04 12:50:41 PST
Comment on attachment 273026 [details]
Patch v1

No cq+, since EWS is not done yet.
Comment 4 David Kilzer (:ddkilzer) 2016-03-04 12:53:32 PST
(In reply to comment #3)
> Comment on attachment 273026 [details]
> Patch v1
> 
> No cq+, since EWS is not done yet.

Huh?  EWS doesn't wait for in-flight builds to finish?
Comment 5 Alexey Proskuryakov 2016-03-04 12:59:52 PST
No, it never did.

It would try to build itself, but only one configuration.
Comment 6 WebKit Commit Bot 2016-03-04 14:18:00 PST
Comment on attachment 273026 [details]
Patch v1

Clearing flags on attachment: 273026

Committed r197590: <http://trac.webkit.org/changeset/197590>
Comment 7 WebKit Commit Bot 2016-03-04 14:18:05 PST
All reviewed patches have been landed.  Closing bug.