Bug 154988

Summary: [ES6] Make Unicode RegExp pattern parsing conform to the spec
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, keith_miller, mark.lam, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Description Michael Saboff 2016-03-03 16:18:52 PST
The parsing of a RegExp pattern with the unicode flag is more restrictive than without.  This is a follow up to change set r197426 to add those restrictions and corresponding tests.
Comment 1 Michael Saboff 2016-03-03 16:57:30 PST
Created attachment 272800 [details]
Patch
Comment 2 Benjamin Poulain 2016-03-03 17:04:03 PST
Comment on attachment 272800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272800&action=review

> Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp:56
> +    return parse(syntaxChecker, pattern, flags.find('u') != notFound);

flags.contains('u')
Comment 3 Geoffrey Garen 2016-03-03 17:04:34 PST
r=me
Comment 4 Michael Saboff 2016-03-03 17:24:18 PST
Committed r197534: <http://trac.webkit.org/changeset/197534>