Bug 154988

Summary: [ES6] Make Unicode RegExp pattern parsing conform to the spec
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, keith_miller, mark.lam, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Michael Saboff
Reported 2016-03-03 16:18:52 PST
The parsing of a RegExp pattern with the unicode flag is more restrictive than without. This is a follow up to change set r197426 to add those restrictions and corresponding tests.
Attachments
Patch (28.09 KB, patch)
2016-03-03 16:57 PST, Michael Saboff 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2016-03-03 16:57:30 PST
Created attachment 272800 [details] Patch
Benjamin Poulain
Comment 2 2016-03-03 17:04:03 PST
Comment on attachment 272800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272800&action=review > Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp:56 > + return parse(syntaxChecker, pattern, flags.find('u') != notFound); flags.contains('u')
Geoffrey Garen
Comment 3 2016-03-03 17:04:34 PST
r=me
Michael Saboff
Comment 4 2016-03-03 17:24:18 PST
Committed r197534: <http://trac.webkit.org/changeset/197534>
Note You need to log in before you can comment on or make changes to this bug.