Bug 154983

Summary: ComposedTreeIterator may traverse slotted nodes multiple times
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch rniwa: review+

Antti Koivisto
Reported 2016-03-03 14:59:22 PST
Traversal of slotted nodes can escape to real siblings. Those siblings are then traversed again as slotted nodes.
Attachments
patch (9.99 KB, patch)
2016-03-03 15:34 PST, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-03-03 15:34:57 PST
Created attachment 272781 [details] patch
Ryosuke Niwa
Comment 2 2016-03-03 15:54:28 PST
Comment on attachment 272781 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=272781&action=review > LayoutTests/fast/shadow-dom/composed-tree-slots.html:1 > +<script> Missing DOCTYPE. > LayoutTests/fast/shadow-dom/composed-tree-slots.html:49 > +var console = document.querySelector("#console"); Can we use some other variable name to avoid shadowing window.console?
Antti Koivisto
Comment 3 2016-03-30 00:07:00 PDT
http://trac.webkit.org/changeset/197553
Note You need to log in before you can comment on or make changes to this bug.