Bug 154978

Summary: Update style guide to reflect our style of only using "override" or "final" when overriding virtual methods
Product: WebKit Reporter: Saam Barati <saam>
Component: WebKit WebsiteAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, ggaren, jond, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
darin: review+
patch for landing
none
patch for landing v2 none

Description Saam Barati 2016-03-03 11:42:50 PST 
Opposed to only using "virtual" or both "virtual" and "override"
Comment 1 Saam Barati 2016-03-03 23:48:06 PST 
Created attachment 272837 [details]
patch
Comment 2 Darin Adler 2016-03-04 14:06:05 PST 
Comment on attachment 272837 [details]
patch

This is good, but you should probably revise to include the rule about final. We want to use exactly one of final, override, and virtual.
Comment 3 Saam Barati 2016-03-06 14:28:15 PST 
Created attachment 273144 [details]
patch for landing
Comment 4 Saam Barati 2016-03-06 14:29:24 PST 
Created attachment 273145 [details]
patch for landing v2

changed bug title to reflect "final" keyword
Comment 5 Saam Barati 2016-03-06 14:30:29 PST 
landed in:
http://trac.webkit.org/changeset/197643