Bug 154952

Summary: Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/multipage/semantics.html#the-base-element
Description Flags
Patch rniwa: review+, cdumez: commit-queue?

Description Chris Dumez 2016-03-02 20:42:15 PST
Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href as this does not match the specification:

Firefox and Chrome both convert null to the string "null".
Comment 1 Chris Dumez 2016-03-02 21:07:46 PST
Created attachment 272726 [details]
Comment 2 Ryosuke Niwa 2016-03-02 22:09:43 PST
Comment on attachment 272726 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=272726&action=review

> Source/WebCore/ChangeLog:14
> +        No new tests, already covered by existing test.

You're adding a test case to fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html
so you should list that instead of saying there's an existing coverage.
Comment 3 Chris Dumez 2016-03-02 22:31:29 PST
Committed r197494: <http://trac.webkit.org/changeset/197494>