Bug 154952

Summary: Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/multipage/semantics.html#the-base-element
Attachments:
Description Flags
Patch rniwa: review+

Chris Dumez
Reported 2016-03-02 20:42:15 PST
Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href as this does not match the specification: https://html.spec.whatwg.org/multipage/semantics.html#the-base-element Firefox and Chrome both convert null to the string "null".
Attachments
Patch (4.58 KB, patch)
2016-03-02 21:07 PST, Chris Dumez 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-03-02 21:07:46 PST
Created attachment 272726 [details] Patch
Ryosuke Niwa
Comment 2 2016-03-02 22:09:43 PST
Comment on attachment 272726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272726&action=review > Source/WebCore/ChangeLog:14 > + No new tests, already covered by existing test. You're adding a test case to fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html so you should list that instead of saying there's an existing coverage.
Chris Dumez
Comment 3 2016-03-02 22:31:29 PST
Committed r197494: <http://trac.webkit.org/changeset/197494>
Note You need to log in before you can comment on or make changes to this bug.