Bug 154951

Summary: Drop [TreatNullAs=EmptyString] from URL interface attributes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://url.spec.whatwg.org/#api
Attachments:
Description Flags
Patch none

Description Chris Dumez 2016-03-02 20:22:14 PST 
Drop [TreatNullAs=EmptyString] from URL interface attributes to match the specification:
https://url.spec.whatwg.org/#api

Firefox and Chrome both already follow the specification and convert null to the "null" string.
Comment 1 Chris Dumez 2016-03-02 20:24:32 PST 
Created attachment 272724 [details]
Patch
Comment 2 Darin Adler 2016-03-03 08:34:35 PST 
Comment on attachment 272724 [details]
Patch

This seems like the kind of behavior that WebKit-specific content that has never been used with another web engine might rely on. Eventually it will become too risky to make this kind of change unless we have a lot of time to test things like iOS apps before Apple puts out a release with the change in it.
Comment 3 WebKit Commit Bot 2016-03-03 09:25:18 PST 
Comment on attachment 272724 [details]
Patch

Clearing flags on attachment: 272724

Committed r197507: <http://trac.webkit.org/changeset/197507>
Comment 4 WebKit Commit Bot 2016-03-03 09:25:22 PST 
All reviewed patches have been landed.  Closing bug.