Bug 154908 – Make HTML parser construct custom elements

• Component: DOM
• Status: RESOLVED FIXED

[Ryosuke Niwa]

HTML parser should be able to instantiate custom elements.

<rdar://problem/24923735>

[Ryosuke Niwa]

Created attachment 272633 [details]
Adds the support

[Ryosuke Niwa]

Created attachment 272634 [details]
GTK build fix

[Ryosuke Niwa]

Created attachment 272635 [details]
GTK build fix 2

[Antti Koivisto]

Comment on attachment 272635 [details]
GTK build fix 2

View in context: https://bugs.webkit.org/attachment.cgi?id=272635&action=review

r=me

> Source/WebCore/html/parser/HTMLConstructionSite.cpp:666
> +    const AtomicString& localName = token->name();

auto&

> Source/WebCore/html/parser/HTMLConstructionSite.cpp:678
> +        if (customElementInterface && UNLIKELY(definitions)) {

Some of these UNLIKELYs seem questionable. I could imagine content where custom element definitions are common.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:198
> +        if (!newElement) // FIXME: This call to docuemnt() is wrong in some cases.

Spelling 'document'
The comment is too vague, please clarify.
Please move FIXME to a line of its own and use { }

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:201
> +        ASSERT(newElement);

This assert adds no value given the code above.

> Source/WebCore/html/parser/HTMLStackItem.h:105
> +    const AtomicString& namespaceURI = element.get().namespaceURI();

auto&

[Ryosuke Niwa]

Committed r197463: <http://trac.webkit.org/changeset/197463>