Bug 154899

Summary: Subpixel layout: Enable vertical/horizontal subpixel spacing for tables.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

alan
Reported 2016-03-01 19:19:25 PST
SSIA.
Attachments
Patch (44.97 KB, patch)
2016-03-01 21:14 PST, alan 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-03-01 21:14:55 PST
Created attachment 272631 [details] Patch
WebKit Commit Bot
Comment 2 2016-03-01 21:15:50 PST
Attachment 272631 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/StyleInheritedData.h:49: horizontal_border_spacing is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/rendering/style/StyleInheritedData.h:50: vertical_border_spacing is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2016-03-01 21:30:57 PST
Comment on attachment 272631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272631&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + Test: fast/table/hidpi-vertical-and-horizontal-spacing.html Some words here please.
alan
Comment 4 2016-03-02 09:15:58 PST
Committed r197450: <http://trac.webkit.org/changeset/197450>
Note You need to log in before you can comment on or make changes to this bug.