Bug 154880

Summary: iOS EWS is broken
Product: WebKit Reporter: Dean Johnson <dean_johnson>
Component: Tools / TestsAssignee: Dean Johnson <dean_johnson>
Status: RESOLVED FIXED    
Severity: Critical CC: ap, commit-queue, lforschler, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=154821
Attachments:
Description Flags
Patch
none
Patch none

Dean Johnson
Reported 2016-03-01 15:14:05 PST
It looks like https://bugs.webkit.org/show_bug.cgi?id=154821 broke iOS EWS. The fix is adding back `willUseIOSDeviceSDK()` since that pops --sdk off of the argument list.
Attachments
Patch (1.20 KB, patch)
2016-03-01 15:23 PST, Dean Johnson 		no flags
DetailsFormatted DiffDiff
Patch (1.20 KB, patch)
2016-03-01 15:32 PST, Dean Johnson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Johnson
Comment 1 2016-03-01 15:23:39 PST
Created attachment 272596 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2016-03-01 15:24:47 PST
Comment on attachment 272596 [details] Patch r=me
David Kilzer (:ddkilzer)
Comment 3 2016-03-01 15:26:44 PST
Comment on attachment 272596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272596&action=review r- > Tools/Scripts/copy-webkitlibraries-to-product-directory:41 > +willUseIOSDeviceSDK() Need semi-colon. Perl doesn't roll like python. :)
Dean Johnson
Comment 4 2016-03-01 15:32:43 PST
Created attachment 272598 [details] Patch
WebKit Commit Bot
Comment 5 2016-03-01 17:42:55 PST
Comment on attachment 272598 [details] Patch Clearing flags on attachment: 272598 Committed r197430: <http://trac.webkit.org/changeset/197430>
WebKit Commit Bot
Comment 6 2016-03-01 17:42:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.