Bug 154878

Summary:

Timer alignment in separate web processes should not all sync up to the same point.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebCore Misc.

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	cdumez: review+

Description Gavin Barraclough 2016-03-01 14:17:44 PST

This leads to a thundering herd of timers firing concurrently.

Comment 1 Gavin Barraclough 2016-03-01 14:33:08 PST

Created attachment 272592 [details]
Fix

Comment 2 Chris Dumez 2016-03-01 15:05:07 PST

Comment on attachment 272592 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=272592&action=review

r=me

> Source/WebCore/page/DOMTimer.cpp:430
> +        static double randomizedAlignment = randomNumber();

should probably be const.

> Source/WebCore/page/DOMTimer.cpp:431
> +        // Force alignment to randomizedAlignment fraction of the way between alignemntIntervals, e.g.

typo: alignemntIntervals

Comment 3 Gavin Barraclough 2016-03-01 15:33:32 PST

Transmitting file data ..
Committed revision 197415.