Bug 154878

Summary: Timer alignment in separate web processes should not all sync up to the same point.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebCore Misc.Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix cdumez: review+

Gavin Barraclough
Reported 2016-03-01 14:17:44 PST
This leads to a thundering herd of timers firing concurrently.
Attachments
Fix (2.28 KB, patch)
2016-03-01 14:33 PST, Gavin Barraclough 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2016-03-01 14:33:08 PST
Created attachment 272592 [details] Fix
Chris Dumez
Comment 2 2016-03-01 15:05:07 PST
Comment on attachment 272592 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=272592&action=review r=me > Source/WebCore/page/DOMTimer.cpp:430 > + static double randomizedAlignment = randomNumber(); should probably be const. > Source/WebCore/page/DOMTimer.cpp:431 > + // Force alignment to randomizedAlignment fraction of the way between alignemntIntervals, e.g. typo: alignemntIntervals
Gavin Barraclough
Comment 3 2016-03-01 15:33:32 PST
Transmitting file data .. Committed revision 197415.
Note You need to log in before you can comment on or make changes to this bug.