Bug 154862

Summary: Promise.prototype.then should use Symbol.species to construct the return Promise
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Description Keith Miller 2016-03-01 10:33:59 PST 
Promise.prototype.then should use Symbol.species to construct the return Promise
Comment 1 Keith Miller 2016-03-01 10:50:13 PST 
Created attachment 272575 [details]
Patch
Comment 2 Saam Barati 2016-03-01 16:58:20 PST 
Comment on attachment 272575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272575&action=review

> Source/JavaScriptCore/builtins/PromisePrototype.js:46
> +        var constructor = constructor[@symbolSpecies];

Style: remove the "var" here.

> Source/JavaScriptCore/builtins/PromisePrototype.js:47
> +        if (constructor == null)

Is this "==" instead of "===" on purpose for null/undefined case?
Comment 3 Keith Miller 2016-03-01 17:02:12 PST 
Comment on attachment 272575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272575&action=review

>> Source/JavaScriptCore/builtins/PromisePrototype.js:46
>> +        var constructor = constructor[@symbolSpecies];
> 
> Style: remove the "var" here.

fixed.

>> Source/JavaScriptCore/builtins/PromisePrototype.js:47
>> +        if (constructor == null)
> 
> Is this "==" instead of "===" on purpose for null/undefined case?

Yeah.
Comment 4 Keith Miller 2016-03-01 17:08:58 PST 
Committed r197428: <http://trac.webkit.org/changeset/197428>