Bug 154840

Summary: SpeculatedType should be easier to edit
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 154835    
Attachments:
Description Flags
work in progress
none
the patch mark.lam: review+

Description Filip Pizlo 2016-02-29 16:13:48 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-29 16:17:07 PST
Created attachment 272529 [details]
work in progress
Comment 2 Filip Pizlo 2016-02-29 16:26:37 PST
Created attachment 272530 [details]
the patch
Comment 3 Mark Lam 2016-02-29 16:33:56 PST
Comment on attachment 272530 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272530&action=review

r=me

> Source/JavaScriptCore/bytecode/SpeculatedType.h:90
> +static const SpeculatedType SpecBytecodeTop        = SpecHeapTop | SpecEmpty; // It can be any of the above, except for SpecInt52 and SpecDoubleImpureNaN. This is (SpecHeapTop | SpecEmpty).

The comment "This is (SpecHeapTop | SpecEmpty)" now adds no value.
Comment 4 Filip Pizlo 2016-02-29 16:35:49 PST
(In reply to comment #3)
> Comment on attachment 272530 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272530&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/bytecode/SpeculatedType.h:90
> > +static const SpeculatedType SpecBytecodeTop        = SpecHeapTop | SpecEmpty; // It can be any of the above, except for SpecInt52 and SpecDoubleImpureNaN. This is (SpecHeapTop | SpecEmpty).
> 
> The comment "This is (SpecHeapTop | SpecEmpty)" now adds no value.

Removed!
Comment 5 Filip Pizlo 2016-02-29 16:39:35 PST
Landed in http://trac.webkit.org/changeset/197374