Bug 154836

Summary: Make it cheap to #include "JITOperations.h"
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 154835    
Attachments:
Description Flags
the patch mark.lam: review+

Description Filip Pizlo 2016-02-29 13:49:16 PST
The header includes the whole world even though it doesn't have any definitions.  Almost all of the includes could be turned into forward declarations.
Comment 1 Filip Pizlo 2016-02-29 13:53:40 PST
Created attachment 272516 [details]
the patch
Comment 2 Mark Lam 2016-02-29 13:55:44 PST
Comment on attachment 272516 [details]
the patch

r=me
Comment 3 Filip Pizlo 2016-02-29 14:01:20 PST
I will wait for EWS.  I made the bet that SlowPathThingyThing.h can be Project not Private.  That might make some Mac builds sad.
Comment 4 Mark Lam 2016-02-29 14:03:37 PST
(In reply to comment #3)
> I will wait for EWS.  I made the bet that SlowPathThingyThing.h can be
> Project not Private.  That might make some Mac builds sad.

Hmmm, I forgot: new a header file probably means that you'll have to update the VC++ project files as well.
Comment 5 Filip Pizlo 2016-02-29 14:10:42 PST
(In reply to comment #4)
> (In reply to comment #3)
> > I will wait for EWS.  I made the bet that SlowPathThingyThing.h can be
> > Project not Private.  That might make some Mac builds sad.
> 
> Hmmm, I forgot: new a header file probably means that you'll have to update
> the VC++ project files as well.

Oh, I didn't know that!  I'll fix it.
Comment 6 Filip Pizlo 2016-02-29 14:12:31 PST
OK, landing.
Comment 7 Filip Pizlo 2016-02-29 14:15:10 PST
Lnaded in http://trac.webkit.org/changeset/197365