Bug 154824

Summary: Use WTF::Optional for HTMLOListElement::m_start
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, kling, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2016-02-29 10:37:41 PST 
Use WTF::Optional for HTMLOListElement::m_start
Comment 1 Chris Dumez 2016-02-29 10:38:58 PST 
Created attachment 272500 [details]
Patch
Comment 2 Chris Dumez 2016-02-29 10:39:52 PST 
Created attachment 272501 [details]
Patch
Comment 3 Andreas Kling 2016-02-29 12:43:20 PST 
Comment on attachment 272501 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2016-02-29 13:32:20 PST 
Comment on attachment 272501 [details]
Patch

Clearing flags on attachment: 272501

Committed r197364: <http://trac.webkit.org/changeset/197364>
Comment 5 WebKit Commit Bot 2016-02-29 13:32:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2016-02-29 16:10:53 PST 
Now we just have to change those parseHTML functions to return an Optional<> rather than returning a boolean and using an out argument for the parsed values.
Comment 7 Chris Dumez 2016-02-29 16:32:32 PST 
(In reply to comment #6)
> Now we just have to change those parseHTML functions to return an Optional<>
> rather than returning a boolean and using an out argument for the parsed
> values.

Ah, that sounds good indeed :)