Bug 154809

Summary: Web Inspector: Add direct number inputs to Bezier editor
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
After patch is applied none

Devin Rousso
Reported 2016-02-28 22:12:08 PST
Suggested in <https://bugs.webkit.org/show_bug.cgi?id=154739#c0>.
Attachments
Patch (21.59 KB, patch)
2016-02-28 22:22 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
After patch is applied (66.27 KB, image/png)
2016-02-29 11:46 PST, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-28 22:12:34 PST
<rdar://problem/24881465>
Devin Rousso
Comment 2 2016-02-28 22:22:10 PST
Created attachment 272475 [details] Patch
Devin Rousso
Comment 3 2016-02-29 11:46:46 PST
Created attachment 272508 [details] After patch is applied Whoops. Forgot to upload this :)
Timothy Hatcher
Comment 4 2016-02-29 14:18:26 PST
Comment on attachment 272475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272475&action=review > Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117 > + background-color: white; > + border: 1px solid hsl(0, 0%, 60%); > + border-radius: 4px; > + box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%); Why the special appearance? Why was the default not good?
WebKit Commit Bot
Comment 5 2016-02-29 15:06:51 PST
Comment on attachment 272475 [details] Patch Clearing flags on attachment: 272475 Committed r197371: <http://trac.webkit.org/changeset/197371>
WebKit Commit Bot
Comment 6 2016-02-29 15:06:56 PST
All reviewed patches have been landed. Closing bug.
Devin Rousso
Comment 7 2016-02-29 15:50:49 PST
(In reply to comment #4) > Comment on attachment 272475 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272475&action=review > > > Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117 > > + background-color: white; > > + border: 1px solid hsl(0, 0%, 60%); > > + border-radius: 4px; > > + box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%); > > Why the special appearance? Why was the default not good? I was mimicking the appearance of the angle input in the Gradient editor. Also, I personally like rounded borders :P
Note You need to log in before you can comment on or make changes to this bug.