Summary: | Web Inspector: Add direct number inputs to Bezier editor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Devin Rousso
2016-02-28 22:12:08 PST
Created attachment 272475 [details]
Patch
Created attachment 272508 [details]
After patch is applied
Whoops. Forgot to upload this :)
Comment on attachment 272475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272475&action=review > Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117 > + background-color: white; > + border: 1px solid hsl(0, 0%, 60%); > + border-radius: 4px; > + box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%); Why the special appearance? Why was the default not good? Comment on attachment 272475 [details] Patch Clearing flags on attachment: 272475 Committed r197371: <http://trac.webkit.org/changeset/197371> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Comment on attachment 272475 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272475&action=review > > > Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117 > > + background-color: white; > > + border: 1px solid hsl(0, 0%, 60%); > > + border-radius: 4px; > > + box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%); > > Why the special appearance? Why was the default not good? I was mimicking the appearance of the angle input in the Gradient editor. Also, I personally like rounded borders :P |