Bug 154802

Summary: Parse HTMLOLElement.start as per the HTML spec
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Comment 1 Chris Dumez 2016-02-28 15:04:28 PST
Created attachment 272467 [details]
Comment 2 Andreas Kling 2016-02-28 19:47:23 PST
Comment on attachment 272467 [details]

Comment 3 WebKit Commit Bot 2016-02-28 20:36:00 PST
Comment on attachment 272467 [details]

Clearing flags on attachment: 272467

Committed r197307: <http://trac.webkit.org/changeset/197307>
Comment 4 WebKit Commit Bot 2016-02-28 20:36:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2016-02-29 08:47:50 PST
What in the world is that 0xBADBEEF thing about?
Comment 6 Chris Dumez 2016-02-29 09:14:40 PST
(In reply to comment #5)
> What in the world is that 0xBADBEEF thing about?

We only read m_start if m_hasExplicitStart is true. If m_hasExplicitStart is false, we set m_start to 0xBADBEEF to make it clear its value is invalid. Honestly, I feel this should be refactored to use WTF::Optional<>. I'll probably do this in a follow-up.