Bug 15479

Summary: SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rwlbuis
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Remove resolveStyle eric: review+, eric: commit-queue+

Eric Seidel (no email)
Reported 2007-10-12 13:13:29 PDT
SVGStyledElement::resolveStyle(RenderStyle*) must be removed! It shouldn't be necessary now that we have (and use) RenderSVGHiddenContainer (to hold style across things like <defs>). If a filter element doesn't otherwise have style in those cases than it probably isn't "valid" SVG and shouldn't be rendered. It is *possible* that this method may need to exist (to force a manual style resolve for a display:none SVG tree or the like) but in that case it needs to be improved (to walk the whole parent chain instead of the current only check the parent).
Attachments
Remove resolveStyle (2.04 KB, patch)
2011-05-12 11:21 PDT, Rob Buis 		eric: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2011-05-12 11:21:50 PDT
Created attachment 93312 [details] Remove resolveStyle
Rob Buis
Comment 2 2011-05-12 11:34:40 PDT
Committed r86365: <http://trac.webkit.org/changeset/86365>
Note You need to log in before you can comment on or make changes to this bug.