Bug 154783

Summary: REGRESSION (r192252): Allow display: none on -webkit-media-controls
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, commit-queue, dbates, koivisto, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review-

alan
Reported 2016-02-27 17:30:15 PST
rdar://problem/24245117
Attachments
Patch (13.66 KB, patch)
2016-02-27 18:18 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.69 KB, patch)
2016-02-27 18:19 PST, alan 		simon.fraser: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-02-27 18:18:42 PST
Created attachment 272430 [details] Patch
alan
Comment 2 2016-02-27 18:19:42 PST
Created attachment 272431 [details] Patch
WebKit Commit Bot
Comment 3 2016-02-27 18:20:27 PST
Attachment 272431 [details] did not pass style-queue: ERROR: Source/WebCore/css/StyleResolver.cpp:844: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 4 2016-02-28 20:22:46 PST
Comment on attachment 272431 [details] Patch That's what the 'controls' attribute is for. Authors should not be messing with -webkit-media-controls
alan
Comment 6 2016-02-28 20:26:22 PST
While I agree with "Authors should not be messing with -webkit-media-controls", it is a valid workaround as long as we don't have that full-screen issue fixed.
Ahmad Saleem
Comment 7 2024-07-08 16:22:21 PDT
Is this needed in Modern Media Controls days?
Note You need to log in before you can comment on or make changes to this bug.