Bug 15478

Summary: Declare vars and functions iteratively upon entering an execution context
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: zwarich
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 14868    
Attachments:
Description Flags
Patch
none
Patch2 mjs: review+

Geoffrey Garen
Reported 2007-10-12 12:35:11 PDT
Broken off from bug 14868.
Attachments
Patch (35.16 KB, patch)
2007-10-12 12:35 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch2 (42.33 KB, patch)
2007-10-12 13:05 PDT, Geoffrey Garen 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2007-10-12 12:35:24 PDT
Created attachment 16642 [details] Patch
Geoffrey Garen
Comment 2 2007-10-12 13:05:11 PDT
Created attachment 16643 [details] Patch2 Added some layout tests to the patch.
Maciej Stachowiak
Comment 3 2007-10-13 18:30:33 PDT
Comment on attachment 16643 [details] Patch2 r=me Don't forget to add a ChangeLog. One other comment: you use i++ as the increment in some for loops, I would mildly suggest changing it to ++i. Preincrement vs. postincrement doesn't matter for integers, but it is more efficient for iterators and it is nicer to consistently use that style instead of only when needed.
Geoffrey Garen
Comment 4 2007-10-16 14:46:11 PDT
Added ChangeLog. Changed some i++ to ++i. Committed revision 26682.
Note You need to log in before you can comment on or make changes to this bug.