Bug 154772 – Optimize parseHTMLInteger()

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

Optimize parseHTMLInteger() now that it is used a lot more and that it has decent API test coverage.

[Chris Dumez]

Created attachment 272400 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 272400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272400&action=review

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:176
> +    value = charactersToIntStrict(numberStart, position - numberStart, &ok);

Can we just compute the result in the above loop instead of calling this function?
We're just parsing decimal number here and we've already traversed the entire string.

[Chris Dumez]

Created attachment 272409 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 272409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272409&action=review

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:178
> +    int result = 0;

Why don't we use unsigned here

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:182
> +        if (result > maxMultiplier || (result == maxMultiplier && digitValue > (intMax % base) + isNegative))

So that we can simplify the second condition here?

Now that I'm seeing this code for overflow check, perhaps calling charactersToIntStrict wasn't that bad...

[Chris Dumez]

Created attachment 272418 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 272418 [details]
Patch

Clearing flags on attachment: 272418

Committed r197255: <http://trac.webkit.org/changeset/197255>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.