Bug 154751

Summary: Reduce direct callers of Structure::findStructuresAndMapForMaterialization
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2016-02-26 14:03:25 PST
Reduce direct callers of Structure::findStructuresAndMapForMaterialization.

Structure::findStructuresAndMapForMaterialization has a very subtle locking contract. Most places that use it, simply want to iterate over all of the properties of the structure. For that, we can use Structure::forEachPropertyConcurrently.

Here the code was identical, so just share the code.
Comment 1 Joseph Pecoraro 2016-02-26 14:04:47 PST
Created attachment 272368 [details]
[PATCH] Proposed Fix
Comment 2 Mark Lam 2016-02-26 14:10:15 PST
Comment on attachment 272368 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2016-02-26 14:58:48 PST
Comment on attachment 272368 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 272368

Committed r197210: <http://trac.webkit.org/changeset/197210>
Comment 4 WebKit Commit Bot 2016-02-26 14:58:53 PST
All reviewed patches have been landed.  Closing bug.