Bug 154751

Summary: Reduce direct callers of Structure::findStructuresAndMapForMaterialization
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-02-26 14:03:25 PST
* SUMMARY Reduce direct callers of Structure::findStructuresAndMapForMaterialization. Structure::findStructuresAndMapForMaterialization has a very subtle locking contract. Most places that use it, simply want to iterate over all of the properties of the structure. For that, we can use Structure::forEachPropertyConcurrently. Here the code was identical, so just share the code.
Attachments
[PATCH] Proposed Fix (2.27 KB, patch)
2016-02-26 14:04 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-02-26 14:04:47 PST
Created attachment 272368 [details] [PATCH] Proposed Fix
Mark Lam
Comment 2 2016-02-26 14:10:15 PST
Comment on attachment 272368 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2016-02-26 14:58:48 PST
Comment on attachment 272368 [details] [PATCH] Proposed Fix Clearing flags on attachment: 272368 Committed r197210: <http://trac.webkit.org/changeset/197210>
WebKit Commit Bot
Comment 4 2016-02-26 14:58:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.