Bug 154709

Summary: REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, mitz, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154758    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Myles C. Maxfield 2016-02-25 19:08:04 PST 
REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
Comment 1 Myles C. Maxfield 2016-02-25 19:09:35 PST 
Created attachment 272278 [details]
Patch
Comment 2 Myles C. Maxfield 2016-02-25 19:11:06 PST 
Created attachment 272279 [details]
Patch
Comment 3 Myles C. Maxfield 2016-02-25 19:11:35 PST 
<rdar://problem/24483596>
Comment 4 Alexey Proskuryakov 2016-02-25 20:17:14 PST 
Comment on attachment 272279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272279&action=review

> LayoutTests/platform/mac-wk2/TestExpectations:-449
> -webkit.org/b/154005 [ ElCapitan+ ] fast/text/crash-complex-text-surrogate.html [ Pass Failure ]

What is the difference between this new bug and bug 154005?
Comment 5 Myles C. Maxfield 2016-02-25 20:30:44 PST 
(In reply to comment #4)
> Comment on attachment 272279 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272279&action=review
> 
> > LayoutTests/platform/mac-wk2/TestExpectations:-449
> > -webkit.org/b/154005 [ ElCapitan+ ] fast/text/crash-complex-text-surrogate.html [ Pass Failure ]
> 
> What is the difference between this new bug and bug 154005?

Oh, there isn't one. I'll forward-dup it.
Comment 6 Myles C. Maxfield 2016-02-25 20:31:21 PST 
*** Bug 154005 has been marked as a duplicate of this bug. ***
Comment 7 WebKit Commit Bot 2016-02-25 21:20:49 PST 
Comment on attachment 272279 [details]
Patch

Clearing flags on attachment: 272279

Committed r197158: <http://trac.webkit.org/changeset/197158>
Comment 8 WebKit Commit Bot 2016-02-25 21:20:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Commit Bot 2016-02-26 15:38:35 PST 
Re-opened since this is blocked by bug 154758
Comment 10 mitz 2016-02-26 15:42:47 PST 
(In reply to comment #9)
> Re-opened since this is blocked by bug 154758

Heh, I think that’s because the expected results in the source tree are for the non-auto-activating case. So the patch made the test non-flaky, but always failing. The patch just needs to be committed with new results.
Comment 11 Alexey Proskuryakov 2016-02-27 12:01:32 PST 
Landed updated El Capitan+ result in http://trac.webkit.org/r197257
Comment 12 Ryan Haddad 2016-03-01 16:28:39 PST 
This test still fails, reopening.
Comment 13 Ryan Haddad 2016-03-01 16:32:19 PST 
Marked test as flaky in <http://trac.webkit.org/projects/webkit/changeset/197425>