Bug 154708

Summary:

RenderTheme::controlSize* methods should take const RenderStyle&.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2016-02-25 18:45:00 PST

and not non-const.

Comment 1 zalan 2016-02-25 18:49:54 PST

Created attachment 272277 [details]
Patch

Comment 2 Darin Adler 2016-02-26 08:11:29 PST

Comment on attachment 272277 [details]
Patch

RenderThemeIOS.h:42:17: error: 'popupInternalPaddingRight' marked 'override' but does not override any member functions
    virtual int popupInternalPaddingRight(RenderStyle&) const override;

Comment 3 zalan 2016-02-26 09:22:29 PST

Created attachment 272328 [details]
Patch

Comment 4 WebKit Commit Bot 2016-02-26 09:35:58 PST

Comment on attachment 272328 [details]
Patch

Clearing flags on attachment: 272328

Committed r197170: <http://trac.webkit.org/changeset/197170>

Comment 5 WebKit Commit Bot 2016-02-26 09:36:02 PST

All reviewed patches have been landed.  Closing bug.