Bug 154708

Summary: RenderTheme::controlSize* methods should take const RenderStyle&.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2016-02-25 18:45:00 PST
and not non-const.
Attachments
Patch (13.59 KB, patch)
2016-02-25 18:49 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.90 KB, patch)
2016-02-26 09:22 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-02-25 18:49:54 PST
Created attachment 272277 [details] Patch
Darin Adler
Comment 2 2016-02-26 08:11:29 PST
Comment on attachment 272277 [details] Patch RenderThemeIOS.h:42:17: error: 'popupInternalPaddingRight' marked 'override' but does not override any member functions virtual int popupInternalPaddingRight(RenderStyle&) const override;
alan
Comment 3 2016-02-26 09:22:29 PST
Created attachment 272328 [details] Patch
WebKit Commit Bot
Comment 4 2016-02-26 09:35:58 PST
Comment on attachment 272328 [details] Patch Clearing flags on attachment: 272328 Committed r197170: <http://trac.webkit.org/changeset/197170>
WebKit Commit Bot
Comment 5 2016-02-26 09:36:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.