Bug 154684

Summary: [Win][CMake] Don't use incremental linking
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2016-02-25 10:51:16 PST
The incremental linking features in MSVC create unacceptably long build and link times. Our hand-crafted project files always had "/INCREMENTAL:NO" set, but CMake didn't know to do that.

This change to the CMake rules causes our generated projects to have "/INCREMENTAL:NO" set properly.
Comment 1 Brent Fulgham 2016-02-25 10:51:29 PST
<rdar://problem/24747822>
Comment 2 Brent Fulgham 2016-02-25 11:03:38 PST
Created attachment 272219 [details]
Patch
Comment 3 Brent Fulgham 2016-02-25 11:19:28 PST
Note: The "/INCREMENTAL:YES" is being set by CMake internally:

https://cmake.org/pipermail/cmake/2010-February/035174.html

See local file "cmake-2.8\Modules\Platform\Windows-cl.cmake" for details of this been set.
Comment 4 WebKit Commit Bot 2016-02-25 11:36:47 PST
Comment on attachment 272219 [details]
Patch

Clearing flags on attachment: 272219

Committed r197124: <http://trac.webkit.org/changeset/197124>
Comment 5 WebKit Commit Bot 2016-02-25 11:36:50 PST
All reviewed patches have been landed.  Closing bug.