Bug 154684

Summary:

[Win][CMake] Don't use incremental linking

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Brent Fulgham

Reported 2016-02-25 10:51:16 PST

The incremental linking features in MSVC create unacceptably long build and link times. Our hand-crafted project files always had "/INCREMENTAL:NO" set, but CMake didn't know to do that. This change to the CMake rules causes our generated projects to have "/INCREMENTAL:NO" set properly.

Attachments
Patch (2.50 KB, patch) 2016-02-25 11:03 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2016-02-25 10:51:29 PST

<rdar://problem/24747822>

Brent Fulgham

Comment 2 2016-02-25 11:03:38 PST

Created attachment 272219 [details] Patch

Brent Fulgham

Comment 3 2016-02-25 11:19:28 PST

Note: The "/INCREMENTAL:YES" is being set by CMake internally: https://cmake.org/pipermail/cmake/2010-February/035174.html See local file "cmake-2.8\Modules\Platform\Windows-cl.cmake" for details of this been set.

WebKit Commit Bot

Comment 4 2016-02-25 11:36:47 PST

Comment on attachment 272219 [details] Patch Clearing flags on attachment: 272219 Committed r197124: <http://trac.webkit.org/changeset/197124>

WebKit Commit Bot

Comment 5 2016-02-25 11:36:50 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.