Summary: | Move streams tests from web-platform-tests/streams-api to web-platform-tests/streams | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | Tools / Tests | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, calvaris, commit-queue, lforschler | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2016-02-25 00:17:24 PST
Created attachment 272180 [details]
Patch
Comment on attachment 272180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272180&action=review Easy renaming. Please, make suggested changes in the changelog before landing. > LayoutTests/imported/w3c/ChangeLog:20 > + (test): > + (test.const.highWaterMarkObjectGetter.get highWaterMark): > + (test.const.highWaterMarkObjectGetterThrowing.get highWaterMark): > + (set string_appeared_here): > + (test.const.chunkGetter.get byteLength): > + (test.const.chunkGetterThrowing.get byteLength): > + (test.const.chunk.get byteLength): Please, remove functions empty comments from here and the other files as it is non important and offers no relevant information. Created attachment 272181 [details]
Patch for landing
Thanks for the review. (In reply to comment #2) > Comment on attachment 272180 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272180&action=review > > Easy renaming. Please, make suggested changes in the changelog before > landing. > > > LayoutTests/imported/w3c/ChangeLog:20 > > + (test): > > + (test.const.highWaterMarkObjectGetter.get highWaterMark): > > + (test.const.highWaterMarkObjectGetterThrowing.get highWaterMark): > > + (set string_appeared_here): > > + (test.const.chunkGetter.get byteLength): > > + (test.const.chunkGetterThrowing.get byteLength): > > + (test.const.chunk.get byteLength): > > Please, remove functions empty comments from here and the other files as it > is non important and offers no relevant information. Done in the landing patch. Comment on attachment 272181 [details] Patch for landing Rejecting attachment 272181 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 272181, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Xabier Rodriguez Calvar found in /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/880911 Created attachment 272182 [details]
Patch for landing
(In reply to comment #5) > Comment on attachment 272181 [details] > Patch for landing > > Xabier Rodriguez Calvar found in > /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog does not appear > to be a valid reviewer according to contributors.json. Hum, it seems I should have written "Xabier Rodriguez-Calvar" and not "Xabier Rodriguez Calvar". Let's see if it works now! Comment on attachment 272182 [details] Patch for landing Clearing flags on attachment: 272182 Committed r197090: <http://trac.webkit.org/changeset/197090> All reviewed patches have been landed. Closing bug. |