| Summary: | [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, gyuyoung.kim, lforschler, mcatanzaro, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 154870 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Konstantin Tokarev
2016-02-24 13:13:58 PST
Created attachment 272143 [details]
Patch
Comment on attachment 272143 [details] Patch Clearing flags on attachment: 272143 Committed r197056: <http://trac.webkit.org/changeset/197056> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 154870 Created attachment 272664 [details]
Patch
I've fixed copy-paste bug in POST_BUILD COMMAND implementation and used phony target instead of CMake's PRE_BUILD COMMAND feature because the latter actually generates pre-link target instead of pre-build. Comment on attachment 272664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272664&action=review > ChangeLog:10 > + CMake's PRE_BUILD COMMAND feature because the latter actually > + generates pre-link target instead of pre-build. PRE_BUILD command generates pre-link targets when using ninja but pre-build targets when using Visual Studio. This is more consistent. Comment on attachment 272664 [details] Patch Clearing flags on attachment: 272664 Committed r197468: <http://trac.webkit.org/changeset/197468> All reviewed patches have been landed. Closing bug. |