Bug 154651

Summary: [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, gyuyoung.kim, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154870    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-02-24 13:13:58 PST
Moved PRE/POST_BUILD_COMMAND handling code to WEBKIT_FRAMEWORK macro.
Attachments
Patch (5.80 KB, patch)
2016-02-24 13:18 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2016-03-02 10:24 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-02-24 13:18:31 PST
Created attachment 272143 [details] Patch
WebKit Commit Bot
Comment 2 2016-02-24 15:47:20 PST
Comment on attachment 272143 [details] Patch Clearing flags on attachment: 272143 Committed r197056: <http://trac.webkit.org/changeset/197056>
WebKit Commit Bot
Comment 3 2016-02-24 15:47:24 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 4 2016-03-01 11:44:30 PST
Re-opened since this is blocked by bug 154870
Konstantin Tokarev
Comment 5 2016-03-02 10:24:02 PST
Created attachment 272664 [details] Patch
Konstantin Tokarev
Comment 6 2016-03-02 13:50:15 PST
I've fixed copy-paste bug in POST_BUILD COMMAND implementation and used phony target instead of CMake's PRE_BUILD COMMAND feature because the latter actually generates pre-link target instead of pre-build.
Alex Christensen
Comment 7 2016-03-02 13:54:14 PST
Comment on attachment 272664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272664&action=review > ChangeLog:10 > + CMake's PRE_BUILD COMMAND feature because the latter actually > + generates pre-link target instead of pre-build. PRE_BUILD command generates pre-link targets when using ninja but pre-build targets when using Visual Studio. This is more consistent.
WebKit Commit Bot
Comment 8 2016-03-02 14:45:37 PST
Comment on attachment 272664 [details] Patch Clearing flags on attachment: 272664 Committed r197468: <http://trac.webkit.org/changeset/197468>
WebKit Commit Bot
Comment 9 2016-03-02 14:45:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.