Bug 15465

Summary:

run-webkit-tests is too greedy calculating platform hierarchy

Product:

WebKit

Reporter:

Andrew Wellington <andrew>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Fix	aroben: review+

Andrew Wellington

Reported 2007-10-11 06:26:24 PDT

run-webkit-tests splits the platform test path at any "-" character, including those in paths that are above the WebKit checkout directory. This causes tests to be searched for in both "WebKit" and "WebKit-fb" if running the WebKit-fb tests when you've got a folder setup like this: ~/WebKit/ -- WebKit trunk checkout ~/WebKit-fb/ -- WebKit feature-branch checkout

Attachments
Fix (1.41 KB, patch) 2007-10-11 06:27 PDT, Andrew Wellington	aroben: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Wellington

Comment 1 2007-10-11 06:27:02 PDT

Created attachment 16626 [details] Fix

Adam Roben (:aroben)

Comment 2 2007-10-12 07:03:05 PDT

Comment on attachment 16626 [details] Fix + Fix run-webkit-tests beeing too greedy in trying to split the platform name up Typo: beeing -> being You should put the bugzilla reference in here before you commit. r=me

Andrew Wellington

Comment 3 2007-10-14 05:16:32 PDT

Landed r26592

Note You need to log in before you can comment on or make changes to this bug.