Bug 15465 - run-webkit-tests is too greedy calculating platform hierarchy
Summary: run-webkit-tests is too greedy calculating platform hierarchy
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-10-11 06:26 PDT by Andrew Wellington
Modified: 2007-10-14 05:16 PDT (History)
0 users

See Also:

Fix (1.41 KB, patch)
2007-10-11 06:27 PDT, Andrew Wellington
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wellington 2007-10-11 06:26:24 PDT
run-webkit-tests splits the platform test path at any "-" character, including those in paths that are above the WebKit checkout directory. This causes tests to be searched for in both "WebKit" and "WebKit-fb" if running the WebKit-fb tests when you've got a folder setup like this:

~/WebKit/      -- WebKit trunk checkout
~/WebKit-fb/      -- WebKit feature-branch checkout
Comment 1 Andrew Wellington 2007-10-11 06:27:02 PDT
Created attachment 16626 [details]
Comment 2 Adam Roben (:aroben) 2007-10-12 07:03:05 PDT
Comment on attachment 16626 [details]

+        Fix run-webkit-tests beeing too greedy in trying to split the platform name up

Typo: beeing -> being

You should put the bugzilla reference in here before you commit.

Comment 3 Andrew Wellington 2007-10-14 05:16:32 PDT
Landed r26592