Bug 154628

Summary:

Use IndentTextOrNot instead of passing isFirstLine/shouldIndentText as bool.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, mmaxfield, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+

alan

Reported 2016-02-23 19:03:28 PST

In RenderBlock (availableLogicalWidthForLine etc) and through the dependencies.

Attachments
Patch (32.41 KB, patch) 2016-02-23 20:24 PST, alan	no flags	Details Formatted Diff Diff
Patch (33.44 KB, patch) 2016-02-23 20:46 PST, alan	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2016-02-23 20:24:22 PST

Created attachment 272082 [details] Patch This patch has a source dependency on bug 154019.

alan

Comment 2 2016-02-23 20:46:24 PST

Created attachment 272083 [details] Patch

Simon Fraser (smfr)

Comment 3 2016-02-24 09:20:14 PST

Comment on attachment 272083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272083&action=review > Source/WebCore/rendering/RootInlineBox.cpp:724 > + LayoutUnit nextLeft = blockFlow().logicalLeftOffsetForLine(nextTop, DoNotIndentText); > + LayoutUnit nextRight = blockFlow().logicalRightOffsetForLine(nextTop, DoNotIndentText); > + LayoutUnit newLeft = blockFlow().logicalLeftOffsetForLine(selectionBottom, DoNotIndentText); > + LayoutUnit newRight = blockFlow().logicalRightOffsetForLine(selectionBottom, DoNotIndentText); Seems like DoNot is much more common; maybe make it a default parameter?

Myles C. Maxfield

Comment 4 2016-02-24 09:55:30 PST

Comment on attachment 272083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272083&action=review > Source/WebCore/rendering/RenderBlock.h:125 > + LayoutUnit availableLogicalWidthForLineInRegion(LayoutUnit position, IndentTextOrNot shouldIndentText, RenderRegion* region, LayoutUnit logicalHeight = 0) const I dislike names with "OrNot." How about ShouldIndentText? ShouldIndent? IndentionRequired?

alan

Comment 5 2016-03-02 13:42:13 PST

Committed r197462: <http://trac.webkit.org/changeset/197462>

alan

Comment 6 2016-03-02 13:45:14 PST

(In reply to comment #4) > Comment on attachment 272083 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272083&action=review > > > Source/WebCore/rendering/RenderBlock.h:125 > > + LayoutUnit availableLogicalWidthForLineInRegion(LayoutUnit position, IndentTextOrNot shouldIndentText, RenderRegion* region, LayoutUnit logicalHeight = 0) const > > I dislike names with "OrNot." How about ShouldIndentText? ShouldIndent? > IndentionRequired? I dislike it very much too, but i'd rather have it in a follow-up patch.

Note You need to log in before you can comment on or make changes to this bug.