Bug 154620

Summary: Fix downloads when using NetworkSession
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, cgarcia, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch beidson: review+

Alex Christensen
Reported 2016-02-23 17:42:17 PST
Fix downloads when using NetworkSession
Attachments
Patch (21.94 KB, patch)
2016-02-23 17:42 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (27.44 KB, patch)
2016-02-24 11:26 PST, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-02-23 17:42:35 PST
Created attachment 272071 [details] Patch
Alex Christensen
Comment 2 2016-02-23 17:43:33 PST
Comment on attachment 272071 [details] Patch This first patch fixes all the API tests, but I'm not sure if everything is necessary and there's probably a better way for some of the things.
Alex Christensen
Comment 3 2016-02-24 11:26:44 PST
Created attachment 272127 [details] Patch
Brady Eidson
Comment 4 2016-02-24 13:22:11 PST
Comment on attachment 272127 [details] Patch Makes things work, doesn't break other things, it must be right; Right?
Alex Christensen
Comment 5 2016-02-24 13:44:06 PST
http://trac.webkit.org/changeset/197050
Darin Adler
Comment 6 2016-02-25 08:46:05 PST
Comment on attachment 272127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272127&action=review > Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:281 > auto downloadID = m_downloadMap.take(taskIdentifier); > - ASSERT(downloadID.downloadID()); > return downloadID; In a case like this, I would like to see us remove the local variable when refactoring to remove the line of code in between.
Note You need to log in before you can comment on or make changes to this bug.