Bug 154620

Summary: Fix downloads when using NetworkSession
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, cgarcia, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch beidson: review+

Description Alex Christensen 2016-02-23 17:42:17 PST
Fix downloads when using NetworkSession
Comment 1 Alex Christensen 2016-02-23 17:42:35 PST
Created attachment 272071 [details]
Patch
Comment 2 Alex Christensen 2016-02-23 17:43:33 PST
Comment on attachment 272071 [details]
Patch

This first patch fixes all the API tests, but I'm not sure if everything is necessary and there's probably a better way for some of the things.
Comment 3 Alex Christensen 2016-02-24 11:26:44 PST
Created attachment 272127 [details]
Patch
Comment 4 Brady Eidson 2016-02-24 13:22:11 PST
Comment on attachment 272127 [details]
Patch

Makes things work, doesn't break other things, it must be right; Right?
Comment 5 Alex Christensen 2016-02-24 13:44:06 PST
http://trac.webkit.org/changeset/197050
Comment 6 Darin Adler 2016-02-25 08:46:05 PST
Comment on attachment 272127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272127&action=review

> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:281
>      auto downloadID = m_downloadMap.take(taskIdentifier);
> -    ASSERT(downloadID.downloadID());
>      return downloadID;

In a case like this, I would like to see us remove the local variable when refactoring to remove the line of code in between.