Bug 154615

Summary: Web Inspector: teach the Objective-C protocol generators about --frontend and --backend directives
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, sbarati, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix
none
Proposed Fix timothy: review+, timothy: commit-queue-

Description BJ Burg 2016-02-23 16:37:32 PST
patch^soon
Comment 1 Radar WebKit Bug Importer 2016-02-23 16:38:07 PST
<rdar://problem/24804330>
Comment 2 BJ Burg 2016-02-23 16:48:16 PST
Created attachment 272064 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-02-23 16:49:12 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 BJ Burg 2016-02-23 17:10:50 PST
Created attachment 272067 [details]
Proposed Fix

This needs to land at the same time as an internal change, so do not cq+.
Comment 5 BJ Burg 2016-02-23 17:11:41 PST
(In reply to comment #4)
> Created attachment 272067 [details]
> Proposed Fix
> 
> This needs to land at the same time as an internal change, so do not cq+.

I think there is one other bug that we don't include the Private header from the AutomationProtocolTypes.mm file, but my build might have been stale. Will investigate.
Comment 6 WebKit Commit Bot 2016-02-23 17:13:12 PST
Attachment 272067 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:58:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 BJ Burg 2016-02-23 22:43:13 PST
Committed r197013: <http://trac.webkit.org/changeset/197013>