Bug 154607

Summary:

[ES6] Implement Proxy.[[Delete]]

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	mark.lam: review+

Description Saam Barati 2016-02-23 13:56:06 PST

...

Comment 1 Saam Barati 2016-02-23 17:21:23 PST

Created attachment 272068 [details]
patch

Comment 2 Mark Lam 2016-02-24 09:42:56 PST

Comment on attachment 272068 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272068&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        This patch implements Proxy.[[Construct]] with respect to section 9.5.10 of the ECMAScript spec.

cut and paste error: should be [[Delete]].

> Source/JavaScriptCore/runtime/ProxyObject.cpp:466
> +bool ProxyObject::deletePropertyByIndex(JSCell* cell, ExecState* exec, unsigned propertyName)

Since this function is deletePropertyByIndex, I think a better name for "propertyName" would be "propertyIndex".

Comment 3 Saam Barati 2016-02-24 12:43:45 PST

landed in:
http://trac.webkit.org/changeset/197042