RESOLVED FIXED154607
[ES6] Implement Proxy.[[Delete]] 
https://bugs.webkit.org/show_bug.cgi?id=154607
Summary [ES6] Implement Proxy.[[Delete]]
Saam Barati
Reported 2016-02-23 13:56:06 PST
...
Attachments
patch (14.68 KB, patch)
2016-02-23 17:21 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-02-23 17:21:23 PST
Created attachment 272068 [details] patch
Mark Lam
Comment 2 2016-02-24 09:42:56 PST
Comment on attachment 272068 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=272068&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + This patch implements Proxy.[[Construct]] with respect to section 9.5.10 of the ECMAScript spec. cut and paste error: should be [[Delete]]. > Source/JavaScriptCore/runtime/ProxyObject.cpp:466 > +bool ProxyObject::deletePropertyByIndex(JSCell* cell, ExecState* exec, unsigned propertyName) Since this function is deletePropertyByIndex, I think a better name for "propertyName" would be "propertyIndex".
Saam Barati
Comment 3 2016-02-24 12:43:45 PST
landed in: http://trac.webkit.org/changeset/197042
Note You need to log in before you can comment on or make changes to this bug.