Bug 154607 - [ES6] Implement Proxy.[[Delete]]
Summary: [ES6] Implement Proxy.[[Delete]]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-23 13:56 PST by Saam Barati
Modified: 2016-02-24 12:43 PST (History)
10 users (show)

See Also:

Attachments
patch (14.68 KB, patch)
2016-02-23 17:21 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-02-23 13:56:06 PST 
...
Comment 1 Saam Barati 2016-02-23 17:21:23 PST 
Created attachment 272068 [details]
patch
Comment 2 Mark Lam 2016-02-24 09:42:56 PST 
Comment on attachment 272068 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272068&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        This patch implements Proxy.[[Construct]] with respect to section 9.5.10 of the ECMAScript spec.

cut and paste error: should be [[Delete]].

> Source/JavaScriptCore/runtime/ProxyObject.cpp:466
> +bool ProxyObject::deletePropertyByIndex(JSCell* cell, ExecState* exec, unsigned propertyName)

Since this function is deletePropertyByIndex, I think a better name for "propertyName" would be "propertyIndex".
Comment 3 Saam Barati 2016-02-24 12:43:45 PST 
landed in:
http://trac.webkit.org/changeset/197042