Bug 154597

Summary: WKPreferences should conform to NSCoding
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2016-02-23 11:29:08 PST
WKPreferences should conform to NSCoding
Comment 1 Anders Carlsson 2016-02-23 11:30:48 PST
Created attachment 272038 [details]
Patch
Comment 2 Sam Weinig 2016-02-23 11:54:50 PST
Comment on attachment 272038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272038&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:70
> +
> +    self.minimumFontSize = [coder decodeDoubleForKey:@"minimumFontSize"];

Might be worth adding a comment about how only properties exposed as API get encoded/decoded.
Comment 3 Anders Carlsson 2016-02-23 12:04:32 PST
Committed r196987: <http://trac.webkit.org/changeset/196987>