Bug 154590
| Summary: | [css-grid][css-flex] Make OrderIterator a STL iterator class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | jfernandez, nathan_solomon, rego, sgill26, simon.fraser, svillar, webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 60731 | ||
Manuel Rego Casasnovas
OrderIterator is used by Grid Layout and Flexbox.
From a comment in bug #154336 it would be nice to make it a STL iterator class:
> > Source/WebCore/rendering/RenderGrid.cpp:1184
> > + for (RenderBox* child = m_orderIterator.first(); child; child = m_orderIterator.next()) {
>
> Perhaps not for this patch but we should make OrderIterator a stl
> iterator-like class so that instead of first() and next() we have begin()
> and end() and we could do things like
>
> for (auto child : m_orderIterator)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/134356478>
Nathan Solomon
Pull request: https://github.com/WebKit/WebKit/pull/32474
Nathan Solomon
Pull request: https://github.com/WebKit/WebKit/pull/32475