Summary: | [WinCairo][MediaFoundation] Implement methods to set volume. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | peavo | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
peavo
2016-02-23 02:36:09 PST
Created attachment 272006 [details]
Patch
Comment on attachment 272006 [details]
Patch
Looks good. I meant to r+ this earlier, but it crashed as I pushed publish.
By the way, I noticed a graphics issue with the MediaFoundation video player where sometimes parts of the video will be a frame ahead of the other parts. It looked like the top left 512px x 512px or so was ahead of the rest. Have you seen that?
Comment on attachment 272006 [details] Patch Clearing flags on attachment: 272006 Committed r197015: <http://trac.webkit.org/changeset/197015> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > Comment on attachment 272006 [details] > Patch > > Looks good. I meant to r+ this earlier, but it crashed as I pushed publish. > By the way, I noticed a graphics issue with the MediaFoundation video player > where sometimes parts of the video will be a frame ahead of the other parts. > It looked like the top left 512px x 512px or so was ahead of the rest. Have > you seen that? No, I haven't seen that. Is it something new? Is it reproducible on a specific page? Thanks for reviewing :) (In reply to comment #5) > No, I haven't seen that. Is it something new? Is it reproducible on a > specific page? I saw it on vimeo.com |