Summary: | Remove IteratorKey and IteratorValue declarations from JSXX class declarations. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebKit Misc. | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, cgarcia, commit-queue, mmaxfield | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2016-02-23 01:49:11 PST
Created attachment 271998 [details]
Patch
Comment on attachment 271998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271998&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-1062 > - if ($interface->iterable) { > - push(@headerContent, "\n"); > - if ($interface->iterable->keyType) { > - my $keyType = GetNativeType($interface->iterable->keyType); > - push(@headerContent, " using IteratorKey = $keyType;\n"); > - } > - my $valueType = GetNativeType($interface->iterable->valueType); > - push(@headerContent, " using IteratorValue = $valueType;\n"); > - } > - Please delete the line from GetNativeType() that special-cases FontFace too. Created attachment 272112 [details]
Patch for landing
Thanks for the review.
> Please delete the line from GetNativeType() that special-cases FontFace too.
Done in the landing patch.
Comment on attachment 272112 [details] Patch for landing Clearing flags on attachment: 272112 Committed r197028: <http://trac.webkit.org/changeset/197028> All reviewed patches have been landed. Closing bug. |