Bug 154577

Summary: Remove IteratorKey and IteratorValue declarations from JSXX class declarations.
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebKit Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2016-02-23 01:49:11 PST
Based on bug 154531, we no longer need these type declarations.
Comment 1 youenn fablet 2016-02-23 01:52:37 PST
Created attachment 271998 [details]
Patch
Comment 2 Myles C. Maxfield 2016-02-23 11:27:32 PST
Comment on attachment 271998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271998&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-1062
> -    if ($interface->iterable) {
> -        push(@headerContent, "\n");
> -        if ($interface->iterable->keyType) {
> -            my $keyType = GetNativeType($interface->iterable->keyType);
> -            push(@headerContent, "    using IteratorKey = $keyType;\n");
> -        }
> -        my $valueType = GetNativeType($interface->iterable->valueType);
> -        push(@headerContent, "    using IteratorValue = $valueType;\n");
> -    }
> -

Please delete the line from GetNativeType() that special-cases FontFace too.
Comment 3 youenn fablet 2016-02-24 05:19:28 PST
Created attachment 272112 [details]
Patch for landing
Comment 4 youenn fablet 2016-02-24 05:20:29 PST
Thanks for the review.

> Please delete the line from GetNativeType() that special-cases FontFace too.

Done in the landing patch.
Comment 5 WebKit Commit Bot 2016-02-24 06:17:45 PST
Comment on attachment 272112 [details]
Patch for landing

Clearing flags on attachment: 272112

Committed r197028: <http://trac.webkit.org/changeset/197028>
Comment 6 WebKit Commit Bot 2016-02-24 06:17:49 PST
All reviewed patches have been landed.  Closing bug.