Bug 154568

Summary: Add tests for fast click change in r196679
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mmaxfield: review+

Description Dean Jackson 2016-02-22 17:22:17 PST
Add tests for fast click change in r196679
Comment 1 Radar WebKit Bug Importer 2016-02-22 17:23:07 PST
<rdar://problem/24782479>
Comment 2 Dean Jackson 2016-02-22 17:27:14 PST
Created attachment 271972 [details]
Patch
Comment 3 Myles C. Maxfield 2016-02-22 17:35:53 PST
Comment on attachment 271972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271972&action=review

> LayoutTests/platform/ios-simulator/TestExpectations:2845
> +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-sends-click.html  [ Pass Timeout ]
> +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-text.html  [ Pass Timeout ]
> +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-image.html  [ Pass Timeout ]
> +webkit.org/b/152134 fast/events/ios/no-fast-click-double-tap-causes-zoom.html  [ Pass Timeout ]

Can we do something to make sure these never timeout?
Comment 4 Dean Jackson 2016-02-23 10:52:05 PST
(In reply to comment #3)

> > LayoutTests/platform/ios-simulator/TestExpectations:2845
> > +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-sends-click.html  [ Pass Timeout ]
> > +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-text.html  [ Pass Timeout ]
> > +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-image.html  [ Pass Timeout ]
> > +webkit.org/b/152134 fast/events/ios/no-fast-click-double-tap-causes-zoom.html  [ Pass Timeout ]
> 
> Can we do something to make sure these never timeout?

Fix webkit.org/b/152134 ?

I've filed a radar and assigned it to Simon. I'm not sure if it is the UI scripting stuff that's causing the issue.

Maybe we should turn that off and see if it still happens.
Comment 5 Dean Jackson 2016-02-23 12:40:00 PST
Committed r196989: <http://trac.webkit.org/changeset/196989>