Bug 154556

Summary: [cmake] Set precompiled headers via ${_target}_PRECOMPILED_HEADER variables.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: achristensen, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch achristensen: review-

Konstantin Tokarev
Reported 2016-02-22 13:55:44 PST
This patch allows customization of precompiled headers in Platform files.
Attachments
Patch (4.80 KB, patch)
2016-02-22 14:00 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (4.80 KB, patch)
2016-02-23 02:15 PST, Konstantin Tokarev 		achristensen: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-02-22 14:00:24 PST
Created attachment 271954 [details] Patch
Konstantin Tokarev
Comment 2 2016-02-23 02:15:12 PST
Created attachment 272002 [details] Patch
Alex Christensen
Comment 3 2016-02-23 09:18:59 PST
Comment on attachment 272002 [details] Patch I don't think this reduces complexity at all. Why is this a useful change?
Konstantin Tokarev
Comment 4 2016-02-23 09:43:25 PST
It allows setting different precompiled headers for different ports.. OK, I probably shoudn't have submitted this change until PCH support for gcc/clang is ready.
Alex Christensen
Comment 5 2016-02-23 22:49:12 PST
Comment on attachment 272002 [details] Patch I agree. As-is, this patch adds nothing, but it makes it a little harder to see what is going on with the precompiled headers.
Note You need to log in before you can comment on or make changes to this bug.