Bug 154544

Summary:

Refactor CoreVideo API access into their own classes so code can be re-used.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, eric.carlson, ossy

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=169931

Bug Depends on:

Bug Blocks:

125157

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	eric.carlson: review+
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Jer Noble

Reported 2016-02-22 11:17:23 PST

Refactor CoreVideo API access into their own classes so code can be re-used.

Attachments
Patch (85.73 KB, patch) 2016-02-22 11:21 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (85.73 KB, patch) 2016-02-22 13:00 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (85.70 KB, patch) 2016-02-22 13:10 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (86.20 KB, patch) 2016-02-22 13:21 PST, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
Patch for landing (86.66 KB, patch) 2016-02-22 22:50 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (87.54 KB, patch) 2016-02-29 13:15 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (87.56 KB, patch) 2016-02-29 13:52 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (87.55 KB, patch) 2016-02-29 14:07 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (87.74 KB, patch) 2016-02-29 14:39 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (87.77 KB, patch) 2016-02-29 14:55 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (87.58 KB, patch) 2016-02-29 15:10 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (89.27 KB, patch) 2016-02-29 16:09 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2016-02-22 11:21:07 PST

Created attachment 271936 [details] Patch

Jer Noble

Comment 2 2016-02-22 13:00:54 PST

Created attachment 271944 [details] Patch

Jer Noble

Comment 3 2016-02-22 13:10:38 PST

Created attachment 271946 [details] Patch

Jer Noble

Comment 4 2016-02-22 13:21:09 PST

Created attachment 271949 [details] Patch

Eric Carlson

Comment 5 2016-02-22 13:39:17 PST

Comment on attachment 271949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271949&action=review > Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp:42 > + VTPixelBufferConformerRef conformer = 0; Nit: nullptr? > Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp:44 > + m_pixelConformer = adoptCF(conformer); Nit: I'll bet the various VTPixelBufferConformer calls aren't NULL safe, so an ASSERT(conformer) and/or the OSStatus returned by VTPixelBufferConformerCreateWithAttributes here might be useful. > Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.h:41 > + PixelBufferConformerCV(CFDictionaryRef attributes); Nit: the parameter name isn't necessary.

Jer Noble

Comment 6 2016-02-22 22:50:00 PST

Created attachment 271991 [details] Patch for landing

Jer Noble

Comment 7 2016-02-29 13:15:45 PST

Created attachment 272512 [details] Patch for landing

Jer Noble

Comment 8 2016-02-29 13:52:04 PST

Created attachment 272515 [details] Patch for landing

Jer Noble

Comment 9 2016-02-29 14:07:26 PST

Created attachment 272517 [details] Patch for landing

Jer Noble

Comment 10 2016-02-29 14:39:24 PST

Created attachment 272519 [details] Patch for landing

Jer Noble

Comment 11 2016-02-29 14:55:17 PST

Created attachment 272520 [details] Patch for landing

Jer Noble

Comment 12 2016-02-29 15:10:13 PST

Created attachment 272523 [details] Patch for landing

Jer Noble

Comment 13 2016-02-29 16:09:40 PST

Created attachment 272527 [details] Patch for landing

Jer Noble

Comment 14 2016-02-29 16:44:54 PST

Committed r197375: <http://trac.webkit.org/changeset/197375>

Csaba Osztrogonác

Comment 15 2016-03-01 00:21:18 PST

(In reply to comment #14) > Committed r197375: <http://trac.webkit.org/changeset/197375> It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:56:9: fatal error: 'PixelBufferConformerCV.h' file not found #import "PixelBufferConformerCV.h" ^

Csaba Osztrogonác

Comment 16 2016-03-01 03:54:55 PST

fixed by https://trac.webkit.org/changeset/197397 ( But the build is still broken because of bug154518 )

Csaba Osztrogonác

Comment 17 2016-03-01 03:59:12 PST

One more fix landed in http://trac.webkit.org/changeset/197398

Note You need to log in before you can comment on or make changes to this bug.