Summary: | Refactor CoreVideo API access into their own classes so code can be re-used. | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | achristensen, eric.carlson, ossy | ||||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=169931 | ||||||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||||||
Bug Blocks: | 125157 | ||||||||||||||||||||||||||||
Attachments: |
|
Description
Jer Noble
2016-02-22 11:17:23 PST
Created attachment 271936 [details]
Patch
Created attachment 271944 [details]
Patch
Created attachment 271946 [details]
Patch
Created attachment 271949 [details]
Patch
Comment on attachment 271949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271949&action=review > Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp:42 > + VTPixelBufferConformerRef conformer = 0; Nit: nullptr? > Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp:44 > + m_pixelConformer = adoptCF(conformer); Nit: I'll bet the various VTPixelBufferConformer calls aren't NULL safe, so an ASSERT(conformer) and/or the OSStatus returned by VTPixelBufferConformerCreateWithAttributes here might be useful. > Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.h:41 > + PixelBufferConformerCV(CFDictionaryRef attributes); Nit: the parameter name isn't necessary. Created attachment 271991 [details]
Patch for landing
Created attachment 272512 [details]
Patch for landing
Created attachment 272515 [details]
Patch for landing
Created attachment 272517 [details]
Patch for landing
Created attachment 272519 [details]
Patch for landing
Created attachment 272520 [details]
Patch for landing
Created attachment 272523 [details]
Patch for landing
Created attachment 272527 [details]
Patch for landing
Committed r197375: <http://trac.webkit.org/changeset/197375> (In reply to comment #14) > Committed r197375: <http://trac.webkit.org/changeset/197375> It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:56:9: fatal error: 'PixelBufferConformerCV.h' file not found #import "PixelBufferConformerCV.h" ^ fixed by https://trac.webkit.org/changeset/197397 ( But the build is still broken because of bug154518 ) One more fix landed in http://trac.webkit.org/changeset/197398 |