Summary: | Web Inspector: Dim selected items when docked Inspector window is inactive | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Created attachment 271905 [details]
WIP
What do you think?
Looks good. We should do this. Comment on attachment 271905 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=271905&action=review > Source/WebInspectorUI/UserInterface/Views/Variables.css:35 > + --selected-color: white; Maybe --selected-foreground-color? Created attachment 272057 [details]
[Animated GIF] Xcode active/inactive window
When Xcode window isn't in focus, the color of selected items and glyphs
is dim blue, not grey. Should we do the same?
Yeah, for the buttons I think it makes sense to use a dim blue like Xcode. I noticed after looking again at your Inspector GIF that the toolbar toggle button in the navigation bar is looks disabled when the window is inactive. That does not look right. Maybe the blue will help. Created attachment 272094 [details]
Patch
Created attachment 272095 [details]
[Animated GIF] Active/inactive
Created attachment 272097 [details]
[Image] Clipped icons
Accidentally, this patch also fixes the bug with clipped icons
by switching away from using opacity on SVG elements, which
appears to be a WebKit bug.
(In reply to comment #9) > Created attachment 272097 [details] > [Image] Clipped icons > > Accidentally, this patch also fixes the bug with clipped icons > by switching away from using opacity on SVG elements, which > appears to be a WebKit bug. To clarify, this image shows how it looked before the patch. Comment on attachment 272094 [details]
Patch
Great!
Comment on attachment 272094 [details] Patch Clearing flags on attachment: 272094 Committed r197029: <http://trac.webkit.org/changeset/197029> All reviewed patches have been landed. Closing bug. |
Created attachment 271903 [details] [Animated GIF] Active/inactive This would match OS X behavior.