Bug 154508

Summary: Web Inspector: it should be possible to omit generated code guarded by INSPECTOR_ALTERNATE_DISPATCHERS
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, sbarati, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix timothy: review+

Description BJ Burg 2016-02-20 22:37:03 PST
patch coming.
Comment 1 Radar WebKit Bug Importer 2016-02-20 22:37:19 PST
<rdar://problem/24759077>
Comment 2 BJ Burg 2016-02-20 22:51:23 PST
Created attachment 271876 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-02-20 22:52:47 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2016-02-20 22:52:55 PST
Attachment 271876 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:70:  [CppBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:205:  [CppBackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:59:  [CppBackendDispatcherImplementationGenerator.generate_output] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:281:  [CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 BJ Burg 2016-02-21 16:08:35 PST
Committed r196881: <http://trac.webkit.org/changeset/196881>