Summary: | Make HTMLSelectElement.size behave as per the specification | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, rniwa, sam | ||||||
Priority: | P2 | Keywords: | WebExposed | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | https://html.spec.whatwg.org/#htmlselectelement | ||||||||
Attachments: |
|
Description
Chris Dumez
2016-02-20 13:31:12 PST
Created attachment 271871 [details]
Patch
Comment on attachment 271871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271871&action=review > Source/WebCore/html/HTMLSelectElement.idl:35 > +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > + attribute unsigned long size; > +#else > attribute long size; > +#endif Since the non-unsigned thing is only there for backward compatibility, I would prefer it if that side was the one that listed languages (Objective-C, GObject bindings). > LayoutTests/ChangeLog:20 > + * fast/forms/select-size.html: > + * platform/mac/fast/forms/select-size-expected.png: > + * platform/mac/fast/forms/select-size-expected.txt: Can we change this into a reference test? It seems like a natural for that. Created attachment 271902 [details]
Patch
Comment on attachment 271902 [details] Patch Clearing flags on attachment: 271902 Committed r196893: <http://trac.webkit.org/changeset/196893> All reviewed patches have been landed. Closing bug. |