Bug 154498 – Enhance logging: Add "always on" macros

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Keith Rollin]

Add macros to Assertions.h/.cpp to be used for "always on" logging. This is logging that we want in both debug and release code, the former for development purposes, the latter so that we can capture information to help diagnose issues that occur on customers' systems.

[Radar WebKit Bug Importer]

<rdar://problem/24757759>

[Keith Rollin]

Created attachment 272051 [details]
Patch

[David Kilzer (:ddkilzer)]

The content of attachment 272051 [details] has been deleted by
    David Kilzer (:ddkilzer) <[e-mail]>
who provided the following reason:

Yes

The token used to delete this attachment was generated at 2016-02-24 16:30:04 PST.

[Keith Rollin]

Created attachment 272338 [details]
Patch

[Chris Dumez]

Comment on attachment 272338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272338&action=review

> Source/WTF/wtf/Assertions.h:388
> +#define LOG_ALWAYS_ERROR(format, ...) WTFLogAlways(format, ##__VA_ARGS__)

Shouldn't this do something similar to LOG_ERROR?

[Keith Rollin]

Created attachment 272361 [details]
Patch

[Build Bot]

Comment on attachment 272361 [details]
Patch

Attachment 272361 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/887355

New failing tests:
storage/indexeddb/odd-strings-private.html

[Build Bot]

Created attachment 272372 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Comment on attachment 272361 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 272361 [details]
Patch

Rejecting attachment 272361 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 272361, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/887543

[Chris Dumez]

Comment on attachment 272361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272361&action=review

> Source/WTF/ChangeLog:7
> +        Reviewed by NOBODY (OOPS).

Isn't supposed to be (OOPS!)??

[Keith Rollin]

Created attachment 272373 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 272373 [details]
Patch

Clearing flags on attachment: 272373

Committed r197214: <http://trac.webkit.org/changeset/197214>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.