Summary: | Enhance logging: Add "always on" macros | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||||||||||
Component: | Web Template Framework | Assignee: | Keith Rollin <krollin> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | ap, benjamin, cdumez, cmarcelo, commit-queue, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 154499 | ||||||||||||||
Attachments: |
|
Description
Keith Rollin
2016-02-20 11:49:46 PST
Created attachment 272051 [details]
Patch
The content of attachment 272051 [details] has been deleted by David Kilzer (:ddkilzer) <ddkilzer@webkit.org> who provided the following reason: Yes The token used to delete this attachment was generated at 2016-02-24 16:30:04 PST. Created attachment 272338 [details]
Patch
Comment on attachment 272338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272338&action=review > Source/WTF/wtf/Assertions.h:388 > +#define LOG_ALWAYS_ERROR(format, ...) WTFLogAlways(format, ##__VA_ARGS__) Shouldn't this do something similar to LOG_ERROR? Created attachment 272361 [details]
Patch
Comment on attachment 272361 [details] Patch Attachment 272361 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/887355 New failing tests: storage/indexeddb/odd-strings-private.html Created attachment 272372 [details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 272361 [details]
Patch
r=me
Comment on attachment 272361 [details] Patch Rejecting attachment 272361 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 272361, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/887543 Comment on attachment 272361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272361&action=review > Source/WTF/ChangeLog:7 > + Reviewed by NOBODY (OOPS). Isn't supposed to be (OOPS!)?? Created attachment 272373 [details]
Patch
Comment on attachment 272373 [details] Patch Clearing flags on attachment: 272373 Committed r197214: <http://trac.webkit.org/changeset/197214> All reviewed patches have been landed. Closing bug. |