Summary: | Web Inspector: Placeholder text in Visual Styles sidebar table row should be white | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
I don't quite understand this placeholder text:
> (modify the boxes below to add a value)
Which boxes? Why do I need to modify them if I can
just click on the placeholder and enter "fantasy"?
I suggest:
1. To make placeholder text gray on a transparent background.
2. Replace the text with the computed (i.e. inherited) font-family
value.
(In reply to comment #2) > I don't quite understand this placeholder text: > > > (modify the boxes below to add a value) > > Which boxes? Why do I need to modify them if I can > just click on the placeholder and enter "fantasy"? I see, this placeholder text makes sense for Background -> Style and Background -> Box Shadow. Created attachment 271846 [details]
Patch
I set the placeholder color to be semi-transparent white
to make it distinguishable from user entered values, which
are just white.
Created attachment 271847 [details]
[Image] With the patch applied
(In reply to comment #0) > Created attachment 271837 [details] > Screenshot of the Bug > > The placeholder text is gray and hard to read. It should be a transparent > white (rgba(255, 255, 255, 0.8)) when selected and focused to stand out on > the blue row background. Whoops, I set the alpha channel to 0.7 and not 0.8. Do we use 0.8 value somewhere else? Comment on attachment 271846 [details] Patch Clearing flags on attachment: 271846 Committed r196857: <http://trac.webkit.org/changeset/196857> All reviewed patches have been landed. Closing bug. |
Created attachment 271837 [details] Screenshot of the Bug The placeholder text is gray and hard to read. It should be a transparent white (rgba(255, 255, 255, 0.8)) when selected and focused to stand out on the blue row background.